Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for issuer authorities #2870

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davux
Copy link

@davux davux commented Apr 23, 2021

Add types and classes related to issue #2854:

  • IssuerScope
  • issuerFor
  • hasIssuingAuthority
  • delegationDepth

Add types and classes relative to issue schemaorg#2854:
  - IssuerScope
  - issuerFor
  - hasIssuingAuthority
  - delegationDepth
@RichardWallis
Copy link
Contributor

I would suggest that these new terms, if generally accepted, should be first placed in the pending area to enable assessment of use before moving into the core of the vocabulary.

It would also be helpful if they were accompanied by some examples so that potential implementers can gain insight as to how they would be used in a real world situation.

Also to add context to your proposal, who would consume such information?

@davux
Copy link
Author

davux commented Apr 26, 2021

Thanks for the suggestions @RichardWallis.

I did include a few examples on issue #2854, is that what you had in mind? Or do you mean in the description of each term in the schema?

As for the inclusion in pending, is that a different process or is this PR OK?

@RichardWallis
Copy link
Contributor

To be placed in pending, a .ttl file containing the term definitions (the convention being it is named after the original issue) should be placed in the data/ext/pending directory. Plus all such terms should be marked :isPartOf <https://pending.schema.org> ; - see others in directory (eg. issue-1758.ttl)

As for examples, that would appear on the term definition pages. What you included in your issue comments could indeed be part of a real, or imagined, example showing how you would mark up related entities using these terms. Such as detailed in issue-1758-examples.txt

@davux
Copy link
Author

davux commented May 4, 2021

Thanks for the suggestions @RichardWallis. I've moved the definition to pending.

As for the examples, I'm seeing a markup that looks like #eg-nnnn that seem to be unique and incrementing numbers. What's the exact rule? How do I make sure there is no clash with other pending contributions?

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This pull request is being tagged as Stale due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants