Feature/add stock options functionality #50
Conversation
CompoTypo
force-pushed
the
feature/add_stock_options_functionality
branch
from
17982da
to
729e02a
Compare
src/ResultDecoder.php
Outdated
| public function transformOptions(string $responseBody): array | ||
| { | ||
| $decoded = json_decode($responseBody, true); | ||
| if (!isset($decoded['optionChain']['result']) || !\is_array($decoded['optionChain']['result'])) { | ||
| throw new ApiException('Yahoo Search API returned an invalid result.', ApiException::INVALID_RESPONSE); | ||
| } | ||
|
|
||
| $results = $decoded['optionChain']['result']; | ||
|
|
||
| // Single element is returned directly in "quote" | ||
| return array_map(function (array $item) { | ||
| return $this->createOption($item); | ||
| }, $results); | ||
| } |
There was a problem hiding this comment.
I'd like to have a test case similar to transformQuotes_jsonGiven_createArrayOfQuote for this method. So we can ensure all expected fields are properly mapped.
There was a problem hiding this comment.
PR is updated with additional tests for the options result
CompoTypo
force-pushed
the
feature/add_stock_options_functionality
branch
2 times, most recently
from
d4549dc
to
184edf6
Compare
|
Thank you for the positive words! I do recommend re-reviewing the work since the models are expanded upon greatly since the initial pr. Thank you for your patience. Please let me know if there are any new issues. |
CompoTypo
force-pushed
the
feature/add_stock_options_functionality
branch
2 times, most recently
from
124b0e4
to
17acd21
Compare
|
Wow, you really did a great effort with the unit tests, thank you!
Other than that, I'd be happy to merge that in. |
CompoTypo
force-pushed
the
feature/add_stock_options_functionality
branch
from
17acd21
to
d58d79f
Compare
|
I squashed another commit on top. The changes should take care of those few requests. Have a great weekend! |
|
Thank you for your work. Has been released under v4.10.0 |
This branch contains a small refactor for cookie and crumb acquisition as well as the primary feature of a
getStockOptionsmethod.I have been using this package for quite a while now and love it. I have been getting more into options and I would like to enhance my own personal trading info infra by adding onto this library.
I tried my best to stick to the conventions laid out in the API/decoder and followed the formatting and checks as described in the CONTRIB. Hopefully it is up to standard.
If you have any recommendations or questions, please don't hesitate to comment.
Best,
Compo