Feature/upgrade psalm #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimTools
commented
Feb 22, 2024
| * @extends \IteratorAggregate<array-key, StackTraceFrame> | ||
| * @extends \ArrayAccess<array-key, StackTraceFrame> | ||
| */ | ||
| interface StackTraceInterface extends \IteratorAggregate, \ArrayAccess |
There was a problem hiding this comment.
there is an odd with @impliments annotation I've had to extend the interface to satisfy error
scheb
reviewed
Feb 25, 2024
Adding psalm v5 for php versions which support it
Fixing erros as with v5 Psalm has gottern more strict
JimTools
force-pushed
the
feature/upgrade-psalm
branch
from
df55c55
to
0386fa9
Compare
Dropping Psalm v3 as PHP 7.1 support is also covered under v4.
JimTools
force-pushed
the
feature/upgrade-psalm
branch
from
a6b4f77
to
cec6057
Compare
Repository owner
deleted a comment from
codecov-commenter
Feb 29, 2024
|
Thanks, merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allowing Psalm v5 for versions of PHP which support it, is for maintenance to ensure the package stays up to date and fixing some potential issues which have been flagged as Psalm as it has gotten stricter
closes #28