Fix new Psalm errors

scheb · Oct 14, 2020 · 0564ee9 · 0564ee9
1 parent 0d7fa13
commit 0564ee9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/analyzer/Report/Console/ConsoleReportGenerator.php b/src/analyzer/Report/Console/ConsoleReportGenerator.php
@@ -108,8 +108,9 @@ private function printTombstone(Tombstone $tombstone, string $prefix): void
     {
         $this->output->writeln(sprintf('  [%s] <info>%s</info>', $prefix, (string) $tombstone));
         $this->output->writeln(sprintf('    in <comment>line %s</comment>', $tombstone->getLine()));
-        if ($tombstone->getMethod()) {
-            $this->output->writeln(sprintf('    in method <comment>%s</comment>', $tombstone->getMethod()));
+        $method = $tombstone->getMethod();
+        if ($method) {
+            $this->output->writeln(sprintf('    in method <comment>%s</comment>', $method));
         } else {
             $this->output->writeln(sprintf('    in global scope'));
         }

diff --git a/src/analyzer/Report/Html/Renderer/DashboardRenderer.php b/src/analyzer/Report/Html/Renderer/DashboardRenderer.php
@@ -227,8 +227,9 @@ private function getLastCalled(Vampire $vampire): string
 
     private function getTombstoneScope(Tombstone $tombstone): string
     {
-        if ($tombstone->getMethod()) {
-            return sprintf('method <samp>%s</samp>', htmlspecialchars($tombstone->getMethod()));
+        $method = $tombstone->getMethod();
+        if ($method) {
+            return sprintf('method <samp>%s</samp>', htmlspecialchars($method));
         }
 
         return 'global scope';

diff --git a/src/analyzer/Stock/TombstoneNodeVisitor.php b/src/analyzer/Stock/TombstoneNodeVisitor.php
@@ -70,6 +70,7 @@ private function visitFunctionNode(Function_ $node): void
      */
     private function getNamespacedName($node): string
     {
+        /** @psalm-suppress DocblockTypeContradiction */
         if (!isset($node->namespacedName)) {
             $nodeName = isset($node->name) ? (string) $node->name : '<anonymous>';
             throw new \RuntimeException(sprintf('Node %s of type %s did not provide attribute namespacedName', $nodeName, \get_class($node)));