Skip to content

Commit

Permalink
Remove Nixpkgs-provided poetry from the environment (qmk#17673)
Browse files Browse the repository at this point in the history
The `poetry` package from the used Nixpkgs snapshot triggers the regex
compatibility issue in Nix >= 2.10.0 binaries for `x86_64-darwin`:

    https://www.github.com/NixOS/nix/issues/4758

Remove the `poetry` package from the Nix shell environment for now
(it is not really required to compile QMK, only to develop the Nix shell
environment itself).

In addition, all `poetry` version earlier than 1.1.14 became effectively
non-functional after a breaking change of the PyPI JSON API:

    https://www.github.com/python-poetry/poetry/pull/5973

Updating the `poetry` package is not trivial (just adding it it to
`pyproject.toml` does not work due to dependency version conflicts with
other modules), therefore removing it seems to be the easiest solution
to restore compatibility with new Nix versions while not creating any
major inconvenience for QMK users.
  • Loading branch information
sigprof authored and schattenbrot committed Aug 2, 2022
1 parent 3c76a7c commit b62ceef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ in
mkShell {
name = "qmk-firmware";

buildInputs = [ clang-tools dfu-programmer dfu-util diffutils git pythonEnv poetry niv ]
buildInputs = [ clang-tools dfu-programmer dfu-util diffutils git pythonEnv niv ]
++ lib.optional avr [
pkgsCross.avr.buildPackages.binutils
pkgsCross.avr.buildPackages.gcc8
Expand Down

0 comments on commit b62ceef

Please sign in to comment.