Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDSRV-527 #5564

Draft
wants to merge 3 commits into
base: development/7.70
Choose a base branch
from
Draft

CLDSRV-527 #5564

wants to merge 3 commits into from

Conversation

KazToozs
Copy link
Contributor

@KazToozs KazToozs commented May 6, 2024

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the
current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

@KazToozs
checkpoint: saving data to mem and metadata to file working
9b10e0a 
POST Object saves an object to bucket with the env variables
set to S3DATA=mem and S3METADATA=file.
Currently, bucket policy checking and Vault auth is effectively
bypassed.
Next steps are to move the form data recovery/parsing to the API
level where we can better separate the form fields from the
file data. In the future, this may allow us to get authentication
details before from the fields by moving them before file data handling,
something that may be a performance vulnerability if handled too early
@bert-e
Copy link
Contributor

bert-e commented May 6, 2024

Hello kaztoozs,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 6, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-527 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.70.47

  • 8.6.27

  • 8.7.48

  • 8.8.21

Please check the Fix Version/s of CLDSRV-527, or the target
branch of this pull request.

@KazToozs
drop: checkpoint moving to bucket p
3ffafd3
@KazToozs
checkpoint: saving MD and file data
58a3e3f 
Both MD and File data are now saved properly,
tested with list-objects-v2 and getObject followed
by a cat of the received file to check contents.
This code still currently bypasses authentication.
@bert-e
Copy link
Contributor

bert-e commented May 23, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-527 contains:

  • 7.70.47

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.70.48

  • 8.6.27

  • 8.7.48

  • 8.8.25

Please check the Fix Version/s of CLDSRV-527, or the target
branch of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KazToozs @bert-e