Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/cldsrv 428 put api imp deny #5325

Draft
wants to merge 10 commits into
base: improvement/CLDSRV-427-permission-checks
Choose a base branch
from

Conversation

KazToozs
Copy link
Contributor

@KazToozs KazToozs commented Sep 11, 2023

A significant portion of the tests have been skipped (and marked with TODOs for following tickets) due to the nature of these logic changes making the S3 APIs non-functional. These will be re-enabled in the ensuing tickets and these will likely need to be merged into this branch before making any merge into a dev branch.

So reviewers: pay most attention to the PUT APIs and the logic changes: a large amount of files are only changed to add these skips

@bert-e
Copy link
Contributor

bert-e commented Sep 11, 2023

Hello kaztoozs,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 11, 2023

Branches have diverged

This pull request's source branch improvement/CLDSRV-428-put-api-impDeny has diverged from
development/8.7 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/8.7 into improvement/CLDSRV-428-put-api-impDeny
  • Rebase improvement/CLDSRV-428-put-api-impDeny onto origin/development/8.7

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@KazToozs KazToozs changed the base branch from development/8.7 to improvement/CLDSRV-427-permission-checks September 11, 2023 16:58
@KazToozs KazToozs force-pushed the improvement/CLDSRV-427-permission-checks branch from 117af54 to 548a28d Compare September 12, 2023 09:52
@KazToozs KazToozs force-pushed the improvement/CLDSRV-428-put-api-impDeny branch from d81ebd9 to cd2db8f Compare September 12, 2023 09:53
@KazToozs
Copy link
Contributor Author

KazToozs commented Sep 12, 2023

A significant portion of the tests have been skipped (and marked with TODOs for following tickets) due to the nature of these logic changes making the S3 APIs non-functional. These will be re-enabled in the ensuing tickets and these will likely need to be merged into this branch before making any merge into a dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants