Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stepper): various enhancements and refactor #3781

Merged
merged 10 commits into from
May 23, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Enhancement
  • Refactor

Summarise concisely:

What is expected?

<Stepper /> enhancement:

  • Added a new disabled state
  • Added possibility to navigate throughout the steps for the user by clicking on the bullets
  • Refactor code : use <Stepper.Step /> for the steps instead of a list of children
  • New style overall

The following changes where made:

  1. Updated Stepper style

  2. Created new subComponent to deal with steps

  3. Added interactivity

@lisalupi lisalupi added the enhancement New feature or request label May 16, 2024
@lisalupi lisalupi requested review from PetmePant, matthprost, mhervouet and a team May 16, 2024 13:45
@lisalupi lisalupi self-assigned this May 16, 2024
@lisalupi lisalupi requested review from JulienSaguez and removed request for a team May 16, 2024 13:45
Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: fbe8f92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi changed the title feat(Stepper) : enhancements feat(Stepper): enhancements May 16, 2024
@lisalupi lisalupi changed the title feat(Stepper): enhancements feat(Stepper): various enhancements and refactor May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.49%. Comparing base (638c99a) to head (fbe8f92).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
+ Coverage   93.43%   93.49%   +0.06%     
==========================================
  Files         182      184       +2     
  Lines        5831     5904      +73     
  Branches     2641     2667      +26     
==========================================
+ Hits         5448     5520      +72     
- Misses        383      384       +1     
Files Coverage Δ
packages/ui/src/components/Stepper/index.tsx 100.00% <100.00%> (+1.61%) ⬆️
packages/ui/src/components/Stepper/Step.tsx 98.68% <98.68%> (ø)
...ages/ui/src/components/Stepper/StepperProvider.tsx 90.90% <90.90%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638c99a...fbe8f92. Read the comment docs.

packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
@lisalupi lisalupi marked this pull request as draft May 22, 2024 09:34
@lisalupi lisalupi marked this pull request as ready for review May 22, 2024 16:00
@lisalupi lisalupi merged commit 90dbb2b into main May 23, 2024
11 checks passed
@lisalupi lisalupi deleted the feat/stepper-enhancements branch May 23, 2024 15:42
@github-actions github-actions bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants