-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unitinput #3724
feat: unitinput #3724
Conversation
🦋 Changeset detectedLatest commit: c32741e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
a87b0a5
to
3b117fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
==========================================
+ Coverage 89.58% 89.71% +0.13%
==========================================
Files 190 191 +1
Lines 4206 4260 +54
Branches 632 637 +5
==========================================
+ Hits 3768 3822 +54
Misses 321 321
Partials 117 117
Continue to review full report in Codecov by Sentry.
|
packages/ui/src/components/UnitInput/__stories__/Playground.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2024-05-13.at.15.46.24.mov
Seems like select input keeps the focus when selecting on it while the whole input should have it instead. You might need to erase the default behavior of select input and set your own
packages/ui/src/components/UnitInput/__stories__/State.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/UnitInput/__stories__/Disabled.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except those last feedbacks everything is fine for me congrats! 🚀
Summary
Type
Summarise concisely:
What is expected?
New component
<UnitInput />
!Also, "disabled" is now optional for the options in
The following changes where made:
New component with tests + stories
Optional prop
disabled
for the options in selectinputV2