Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fed prox example #564

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fed prox example #564

wants to merge 6 commits into from

Conversation

mattiasakesson
Copy link
Member

Description

Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and neat. Would it be possible to have a notebook or script that runs vanilla fedavg and fedprox? I guess we would gave to have some significant degree of heterogeneity to have prox show an advnatage?

examples/mnist-pytorch-fedprox/client/entrypoint Outdated Show resolved Hide resolved
@mattiasakesson
Copy link
Member Author

Updated.
I didnt add a notbok instead a wrote some lines in the readme about how to use fedprox and how to turn the example to vanilla fedavg by setting mu=0. I dont think a notebok will make it any clearer, you still have to manually modify the client_settings.yaml file to change the mu parameter.

@ahellander
Copy link
Member

Will it / how will it work with client_settings.yaml in the base directory and not in the 'client' folder?

Also, we need to rework to align with the new model incoming from the "python_env" PR.

@ahellander
Copy link
Member

Given the release with the python_env support, this one needs to be updated to the new client structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants