Feature/SK-736 | Ruff linter #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorvaladi
force-pushed
the
feature/SK-736
branch
from
45ffe79
to
448e3e7
Compare
Wrede
requested changes
Apr 4, 2024
.devcontainer/devcontainer.json.tpl
Outdated
| @@ -23,5 +27,4 @@ | |||
| "BASE_IMG": "python:3.9" | |||
| lint = ["ruff>=0.0.220"] # MIT License (MIT) | ||
|
|
||
| [tool.ruff] | ||
| line-length = 160 |
There was a problem hiding this comment.
is not this very high number?
There was a problem hiding this comment.
Yes, its a very high number, but it's the one that was used on the earlier setup. I think we should lower it in the future
There was a problem hiding this comment.
which earlier setup? We have always used 79 (pep8)
viktorvaladi
force-pushed
the
feature/SK-736
branch
from
819321c
to
60f9382
Compare
Wrede
approved these changes
May 6, 2024
| lint = ["ruff>=0.0.220"] # MIT License (MIT) | ||
|
|
||
| [tool.ruff] | ||
| line-length = 160 |
There was a problem hiding this comment.
which earlier setup? We have always used 79 (pep8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove flake8, autopep8 and isort in favor of Ruff.