Skip to content
This repository has been archived by the owner on May 27, 2020. It is now read-only.

Add and configure sbt-wartremover #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

anbarasantr
Copy link

@anbarasantr anbarasantr commented Jul 20, 2018

fixes #15

  • turned on only the stable warts to just issue warnings instead of errors (Other Scalaz projects which uses the plugin will get affected if we throw error on compilation)

build.sbt Outdated
@@ -18,3 +18,5 @@ addSbtPlugin("com.geirsson" % "sbt-scalafmt" % "1.6.0-RC3")
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.3.3")

scalafmtOnCompile := true

wartremoverWarnings in (Compile, compile) ++= Warts.unsafe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds settings for the wart remover configuration of the plugin itself.
I think we want to add settings to projects using the plugin via the projectSettings method of ScalazPlugin

…e warts are turned off.

We can override the wart remover settings in project
@vil1
Copy link
Contributor

vil1 commented Jul 25, 2018

@xuwei-k there seems to be an authorization problem with the scala-latest test you added earlier that prevents this PR from building correctly. Do you have any idea what would be the cause?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add and configure wartremover
2 participants