Allow testing multipart PATCH requests #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both POST and PUT methods allow users to pass in a list of files to perform a multipart/form-data request but it is missing from the PATCH methods.
seratch
reviewed
Feb 12, 2017
| @@ -94,10 +94,14 @@ trait Client extends ImplicitConversions { | |||
| patch(uri, params)(f) | |||
| def patch[A](uri: String, params: Iterable[(String, String)])(f: => A): A = | |||
| patch(uri, params, Map[String, String]())(f) | |||
| def patch[A](uri: String, params: Iterable[(String, String)], headers: Iterable[(String, String)])(f: => A): A = | |||
| def patch[A](uri: String, params: Iterable[(String, String)], headers: Map[String, String])(f: => A): A = | |||
There was a problem hiding this comment.
This one looks a change for a different purpose (consistency with POST/PUT ..). Although that is a breaking change but if there is no objection from others, I think it's ok to merge for 2.5.1.
There was a problem hiding this comment.
Yes, after adding the new method it wouldn't compile without this change. I think I was getting ambiguity error.
| patch(uri, toQueryString(params).getBytes("UTF-8"), Seq("Content-Type" -> "application/x-www-form-urlencoded; charset=utf-8") ++ headers)(f) | ||
| def patch[A](uri: String, body: Array[Byte] = Array(), headers: Iterable[(String, String)] = Seq.empty)(f: => A): A = | ||
| submit("PATCH", uri, Seq.empty, headers, body) { f } | ||
| def patch[A](uri: String, params: Iterable[(String, String)], files: Iterable[(String, Any)])(f: => A): A = |
There was a problem hiding this comment.
These new methods look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both POST and PUT methods allow users to pass in a list of files to perform a multipart/form-data request but it is missing from the PATCH methods.