Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Scala-JS #307

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Port to Scala-JS #307

wants to merge 2 commits into from

Conversation

nightscape
Copy link

I'm trying to port some parts to Scala-JS in the hope that it will result in a version that might be reduced in terms of functionality, but usable in the browser.
My rough plan is to proceed like this:

  1. Port parsers
  2. Abstract over usages of the compiler
  3. Implement an evaluation engine that evaluates templates instead of compiling them

I've ported handlebars.scala to Scala-JS, so I have a rough overview of what is required and how the evaluation engine should look like.

Unfortunately, this requires a rather large restructuring of the code base to separate JS-compatible stuff from only-JVM.
I hope this is ok @magnolia-k @xuwei-k?
If not, please let me know as soon as possible, so I don't waste time here with something that has little chances of getting merged...

@magnolia-k
Copy link
Contributor

@nightscape

Very interesting project!
However, however, the PR is just too huge to review.

The formatting changes and the logger changes were incorporated at the same time, so I can't judge the validity of this PR.

If there are more fine-grained commits, I think it would be better to break it down and publish the PR, or even better, fork it and let it grow.

Scalate relies heavily on the Scala compiler, which makes it difficult to make major improvements, so this is definitely a very interesting PR.

Translated with www.DeepL.com/Translator (free version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants