Fix datahub tests

scalar-dev · Mar 11, 2024 · acd2bde · acd2bde
1 parent 92a335d
commit acd2bde
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 18 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -33,6 +33,6 @@ jobs:
                   pip install poetry
                   poetry install
 
-                  poetry run pytest -s . || true
+                  poetry run pytest -s .
 
                   docker-compose logs
diff --git a/metadata/api/datahub/api.go b/metadata/api/datahub/api.go
@@ -3,12 +3,9 @@ package datahub
 import (
 	"bytes"
 	"encoding/json"
-	"fmt"
 	"io"
 	"log/slog"
 	"net/http"
-	"os"
-	"strings"
 
 	"metadata/ent"
 
@@ -20,18 +17,18 @@ type datahubApiServer struct {
 	log    *slog.Logger
 }
 
-func writeRequestToFile(data *bytes.Buffer, id string) {
-	path := ".data/" + strings.ReplaceAll(id, "/", "__") + ".json"
-	fmt.Println("Writing path", path)
-	f, err := os.Create(path)
-	if err != nil {
-		fmt.Println(err)
-		os.Exit(1)
-	}
-	f.Write(data.Bytes())
-	f.Close()
+// func writeRequestToFile(data *bytes.Buffer, id string) {
+// 	path := ".data/" + strings.ReplaceAll(id, "/", "__") + ".json"
+// 	fmt.Println("Writing path", path)
+// 	f, err := os.Create(path)
+// 	if err != nil {
+// 		fmt.Println(err)
+// 		os.Exit(1)
+// 	}
+// 	f.Write(data.Bytes())
+// 	f.Close()
 
-}
+// }
 
 func (i *datahubApiServer) Entities(w http.ResponseWriter, r *http.Request) {
 	variables := mux.Vars(r)
@@ -51,8 +48,8 @@ func (i *datahubApiServer) Entities(w http.ResponseWriter, r *http.Request) {
 
 	for _, aspect := range req.Entity.Value.DatasetSnapshot.Aspects {
 		if aspect.SchemaMetadata != nil {
-			urn, _ := parseDatahubUrn(namespace, req.Entity.Value.DatasetSnapshot.Urn)
-			writeRequestToFile(&buf, "entity_"+urn.ToString())
+			// urn, _ := parseDatahubUrn(namespace, req.Entity.Value.DatasetSnapshot.Urn)
+			// writeRequestToFile(&buf, "entity_"+urn.ToString())
 			err := aspectHandler.HandleSchemaMetadata(*aspect.SchemaMetadata)
 
 			if err != nil {
@@ -89,7 +86,7 @@ func (i *datahubApiServer) Aspects(w http.ResponseWriter, r *http.Request) {
 	}
 
 	aspectHandler := CreateAspectHandler(req.Proposal.EntityUrn, req.Proposal.SystemMetadata.RunId, namespace, i.client, r.Context(), i.log)
-	writeRequestToFile(&buf, fmt.Sprintf("aspect_%s_%s", req.Proposal.EntityUrn, req.Proposal.AspectName))
+	// writeRequestToFile(&buf, fmt.Sprintf("aspect_%s_%s", req.Proposal.EntityUrn, req.Proposal.AspectName))
 	if err := aspectHandler.HandleJsonAspect(req.Proposal.AspectName, req.Proposal.Aspect.Value); err != nil {
 		i.log.Error("Error while handling aspect", err)
 		http.Error(w, err.Error(), http.StatusInternalServerError)