Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip insertion of spaces within multi imports. #69

Closed
wants to merge 16 commits into from

Conversation

gbasler
Copy link
Contributor

@gbasler gbasler commented Dec 17, 2012

Fix for #38

@buildhive
Copy link

Matt Russell » scalariform #10 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

Matt Russell » scalariform #11 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Matt Russell » scalariform #12 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Matt Russell » scalariform #13 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Matt Russell » scalariform #14 SUCCESS
This pull request looks good
(what's this?)

@markdrago
Copy link

Are there any plans to merge this pull request? In particular I'm interested in using the noSpacesAroundMultiImports stuff. If it the patches need to be cleaned up to merge, and @gbasler isn't around, I could take a crack at it.

@gbasler
Copy link
Contributor Author

gbasler commented Aug 19, 2013

I'm around but I can't merge the pull request myself 😄 it's also quite a while since I've looked at this, so I wouln't mind if an extra pair of eyes could look at it 😃

@Marza
Copy link

Marza commented Aug 27, 2013

I would love to see this feature merged as well

@coderunner
Copy link

+1 for noSpacesAroundMultiImports

@dbtsai
Copy link

dbtsai commented Jan 18, 2014

++1 Anyone can merge it? Is this community not activity anymore?

@dragos
Copy link
Member

dragos commented Jan 18, 2014

The patch won't merge cleanly anymore, it would be a good first step to rebase on master. Unfortunately, @mdr isn't very active anymore. I'd love this patch as well.

@michalkowol
Copy link

I had forked @gbasler repo, and I rebased it with mdr/master. Pull request is ready: #127

@kiritsuku
Copy link
Member

superseded by #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants