Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust QR Code modal spacing to fix copy icon size on bigger fonts #836

Merged
merged 1 commit into from May 3, 2024

Conversation

Pabl0cks
Copy link
Collaborator

@Pabl0cks Pabl0cks commented May 3, 2024

Description

Fixes #835

Feel free to close this PR if we should not handle issues on different fonts 馃檶. Thought it would good to create because was happening in SRE challenges, but maybe not!

For address 0x04AAa2B551eaAb54568a5546be5d61407cA9D70c is looking like this in Challeneges after fix:

image

Copy link
Collaborator

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks @Pabl0cks 馃檶

@technophile-04 technophile-04 merged commit 6a2221b into main May 3, 2024
1 check passed
@technophile-04 technophile-04 deleted the fix/835-qr-code-modal branch May 3, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust AddressQRCodeModal spacing to fix icon size problem with some fonts
3 participants