Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding engines fields in package.json to hint people #833

Merged
merged 1 commit into from May 2, 2024

Conversation

wolfcito
Copy link
Contributor

@wolfcito wolfcito commented May 1, 2024

Description

I have added 'engines' to the package.json file. This practice ensures consistency in the development environment, which is crucial when collaborating with colleagues who may have different versions of Node.js installed

Additional Information

Your ENS/address: wolfcito.eth

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wolfcito, now it gives more nice error :

When I try to run yarn install :

Screenshot 2024-05-02 at 11 31 32 PM

@technophile-04 technophile-04 merged commit 3a52ce0 into scaffold-eth:main May 2, 2024
1 check passed
@carletex
Copy link
Member

carletex commented May 3, 2024

@technophile-04 curious to know why it says

image

instead of 18.17.0? :

@damianmarti
Copy link
Collaborator

@wolfcito @technophile-04 I ran yarn install using node v16.17.0 and I didn't get any error (yarn installed all the packages).

Maybe I'm doing something wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants