Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use burner-connector package #831

Merged
merged 1 commit into from May 1, 2024
Merged

use burner-connector package #831

merged 1 commit into from May 1, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Apr 30, 2024

Copy link
Collaborator

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Tested both locally and on sepolia, works great!

Copy link
Collaborator

@damianmarti damianmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Sepolia and working great!!

The documentation from the package looks good too!

@technophile-04
Copy link
Collaborator Author

Thanks all for testing !! Merging this 🙌


Also Carlos and I yesterday tried renaming the package to @scaffold-eth/burner-connector so that its scoped. But when we tried registering scaffold-eth "organization" on npm it was saying the name was unavailable :( . Not completely sure if its saying unavailable because there is already registered "package" scaffold-eth by someone. Carlos tried raising a ticket to npm regarding name dispute but not sure when they will reply back.

So for this package we are keeping the name as it is and for future packages we will try to keep it scoped under scaffold-eth, hopefully we will get the org name soon

@technophile-04 technophile-04 merged commit 0abf227 into main May 1, 2024
1 check passed
@technophile-04 technophile-04 deleted the burner-connector branch May 1, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Burner Connector to a different repo / package
3 participants