New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better method to find free port #7083
base: 1.8.x
Are you sure you want to change the base?
Use better method to find free port #7083
Conversation
Hi @mdedetrich, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
07caa2f
to
fb308d3
Compare
fb308d3
to
21ea9f4
Compare
@@ -186,6 +186,7 @@ jobs: | |||
shell: bash | |||
run: | | |||
# test building sbtn on Windows | |||
sbt "commandProj/testOnly xsbt.IPCSpec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make sure the added test runs on Windows
d22853f
to
9557d2f
Compare
9557d2f
to
62c1509
Compare
Setting this to draft for now as I don't think its the actual reason behind sbt scripted tests failing on |
Rather than trying to find random open ports we instead should instead use this technique https://stackoverflow.com/a/2675416 to find free ports which will also work on Windows #7082.