Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent launcher download corruption #6658

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

cbrunnkvist
Copy link

@cbrunnkvist cbrunnkvist commented Sep 13, 2021

Fixes #6654 for both curl and wget cases, and provides feedback on why shasum is unavailable (forcing us to skip checksum verification).

@lightbend-cla-validator

Hi @cbrunnkvist,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@cbrunnkvist cbrunnkvist marked this pull request as ready for review September 13, 2021 11:42
sbt
fi
} && [[ -f "$jar" ]]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of a { ... } block is decided by its final expression - and an if ... fi statement always succeeds (in contrast to e.g. Scala). Consequently, that && was always true.

@cbrunnkvist cbrunnkvist changed the title Prevent curl from masking certain download errors Prevent launcher download corruption Sep 13, 2021
@lightbend-cla-validator

Hi @cbrunnkvist,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@cbrunnkvist
Copy link
Author

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

(in progress)

@lightbend-cla-validator

Hi @cbrunnkvist,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@lightbend-cla-validator

Hi @cbrunnkvist,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@SethTisue SethTisue marked this pull request as draft June 14, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launcher jar left corrupt when bootstrap download "successfully fails"
2 participants