New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent launcher download corruption #6658
base: develop
Are you sure you want to change the base?
Conversation
An attempt at fixing sbt#6654
Hi @cbrunnkvist, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
(and clean up failed downloads)
fi | ||
} && [[ -f "$jar" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result of a { ... }
block is decided by its final expression - and an if ... fi
statement always succeeds (in contrast to e.g. Scala). Consequently, that &&
was always true.
Hi @cbrunnkvist, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
(in progress) |
Hi @cbrunnkvist, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Hi @cbrunnkvist, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Fixes #6654 for both
curl
andwget
cases, and provides feedback on whyshasum
is unavailable (forcing us to skip checksum verification).