Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sbt --version respect SBT_OPTS and friends #6509

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

parched
Copy link

@parched parched commented May 15, 2021

Having set SBT_OPTS="-Dsbt.boot.directory=/not/the/default" I found when I ran sbt --version SBT was being redownloaded into ~/.sbt. This fixes that and I assume SBT_OPTS wasn't ignored on purpose, but I'm not sure.

@lightbend-cla-validator

Hi @parched,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

parched added a commit to parched/polly that referenced this pull request May 15, 2021
Turns out SBT_OPTS was ignored for `--version`. Potential fix sbt/sbt#6509
@eed3si9n
Copy link
Member

This fixes that and I assume SBT_OPTS wasn't ignored on purpose, but I'm not sure.

sbt/sbt-launcher-package#276 added it, and I'm guessing SBT_OPTS was ignored on purpose since mostly those define memory options.

@parched
Copy link
Author

parched commented May 16, 2021

I'm guessing SBT_OPTS was ignored on purpose since mostly those define memory options.

Ok, I'm happy to close the PR if you think that's best? I worked around it by just doing sbt sbtVersion instead so not a blocker for me.

@eed3si9n
Copy link
Member

I think the direction of the change is good but the tests are currently failing. It looks like the previous incantation didn't have color but the new one does?

Copy link
Author

@parched parched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've found the problem, will push a fix when I'm back at my computer.

sbt Outdated Show resolved Hide resolved
sbt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants