Fix undefined var when posting new top-level comment #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent changes module, adding a recent change for a new comment caused the warning "Undefined variable $comment_thread" if the comment was not a reply. Use `isset()` instead of `!== NULL` to check for reply depth, avoiding the warning when $comment_thread is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Here's a small patch for you to consider.
With 0.24, when I post a comment that's not a reply, if the recent_changes module is enabled, I see the following PHP warning and the automatic redirect to my posted comment doesn't work.
This PR fixes the issue. I've tested it on FreeBSD with Apache and PHP 8.0, 8.1, and 8.2.
Thank you for all your work on Pepperminty Wiki—what a fabulous bit of software!
I agree to release this contribution under the Mozilla Public License 2.0.