-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MDNDensityEstimator #1042
base: main
Are you sure you want to change the base?
Add MDNDensityEstimator #1042
Conversation
…oned, and corrected for proposals, bot in SNPE-A and SNPE-C
…oned, and corrected for proposals, bot in SNPE-A and SNPE-C
3ded687
to
7a4d504
Compare
…oned, and corrected for proposals, bot in SNPE-A and SNPE-C
…oned, and corrected for proposals, bot in SNPE-A and SNPE-C
…new-densityestimators' of github.com:sbi-dev/sbi into 989-add-a-common-mdn-network-interface-consistent-with-new-densityestimators
Hi @jnsbck, can you please add a description of this PR? another comment: Thanks 🙏 |
Yea of course. Was planning to continue working on it. Left the desc blank since its in draft state. Yes, can rename it to EDIT: updated the desc. working on this is on my Todo :) |
Ping @jnsbck :) |
Have too much of other stuff on my plate currently, so I have not been actively working on this. Still on my todo though. I hope I will get around to finishing this at some point. Feel free to take the template and add to it though if you need some of the functionality urgently. Will let you know when I start working on it again and where I need help :) |
OK, thank you for the update @jnsbck 🙏 |
…oned, and corrected for proposals, bot in SNPE-A and SNPE-C
What does this implement/fix? Explain your changes
This PR attempts to consolidate the functionalities of the various mixture density objects used throughout the toolbox, for details see #989 into one
MixtureDensityEstimator
. I will try to do this by implementing a MoG object on which conditioning, marginalization and proposal correction can be done if necessary, but it behaves like a Flow otherwise.Does this close any currently open issues?
Fixes #989
Any relevant code examples, logs, error output, etc?
...
Any other comments?
PR is a WIP and subject to change.
dev.ipynb
already contains a working sketch of the implemetation though.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
guidelines
with
pytest.mark.slow
.guidelines
main
(or there are no conflicts withmain
)