Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sourcemap crutch once again #2540

Merged
merged 1 commit into from Jan 20, 2018
Merged

Fix sourcemap crutch once again #2540

merged 1 commit into from Jan 20, 2018

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jan 18, 2018

Fixes #2312

@mgreter mgreter self-assigned this Jan 18, 2018
nschonni
nschonni reviewed Jan 19, 2018
View reviewed changes
Copy link
Collaborator

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the code be deleted rather than just commented out?

@mgreter
Copy link
Contributor Author

mgreter commented Jan 19, 2018

I'd like to keep it in for now in case we get any regressions due to this. I'm pretty sure I've added this for a reason, but due to lacking of any tests regarding source maps I can't really remember why.

@mgreter mgreter merged commit 6892bf5 into sass:master Jan 20, 2018
@entr
Copy link

entr commented Jan 20, 2018

Finally, thanks!

This was referenced Jan 22, 2018
Closed
Closed
Closed
@entr entr mentioned this pull request Jan 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

Assignees

@mgreter mgreter

Labels
Dev - PR Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgreter @entr @nschonni