Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed pkg_resources imports #211

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Fix failed pkg_resources imports #211

merged 3 commits into from
Mar 12, 2020

Conversation

techalchemy
Copy link
Member

Fix parsing of non-utf8 encoded setup.py files

- Fixes #185

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@ghost
Copy link

ghost commented Mar 11, 2020

DeepCode's analysis on #27257f found:

  • 0 critical issues. ⚠️ 1 warning and 0 minor issues. ✔️ 1 issue were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #211 into master will decrease coverage by 0.1%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   63.36%   63.25%   -0.11%     
==========================================
  Files          13       13              
  Lines        5546     5549       +3     
  Branches     1345     1345              
==========================================
- Hits         3514     3510       -4     
- Misses       1583     1589       +6     
- Partials      449      450       +1
Impacted Files Coverage Δ
src/requirementslib/models/setup_info.py 67.31% <60%> (-0.1%) ⬇️
src/requirementslib/models/cache.py 41.57% <0%> (-3.94%) ⬇️
src/requirementslib/models/dependencies.py 57.84% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81ff72...27257f5. Read the comment docs.

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@techalchemy techalchemy merged commit a29e66f into master Mar 12, 2020
@techalchemy techalchemy deleted the bugfix/185 branch March 12, 2020 15:54
techalchemy added a commit that referenced this pull request Mar 31, 2020
Fix failed pkg_resources imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AST parsing fails on non-utf8 setup.py files
1 participant