🔥 removed unused properties from YoutubePlayerValue

sarbagyastha · Aug 14, 2022 · e6d01eb · e6d01eb
1 parent 42758fd
commit e6d01eb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 20 deletions.
diff --git a/packages/youtube_player_iframe/CHANGELOG.md b/packages/youtube_player_iframe/CHANGELOG.md
@@ -4,6 +4,7 @@
 - Added **Migrating to v3** section in the docs.
 - Listed `Swipe up/down to enter/exit fullscreen mode` as a feature in the docs.
 - Deprecated `autoPlay` param in **YoutubePlayerParams**, as it's no longer used.
+- Removed `hasPlayed`, `position` & `buffered` from **YoutubePlayerValue**, as these values can be accessed through **YoutubePlayerController**.
 
 # 3.0.2
 - Improved pub score.

diff --git a/packages/youtube_player_iframe/lib/src/controller/youtube_player_controller.dart b/packages/youtube_player_iframe/lib/src/controller/youtube_player_controller.dart
@@ -230,9 +230,6 @@ class YoutubePlayerController implements YoutubePlayerIFrameAPI {
   /// Creates new [YoutubePlayerValue] with assigned parameters and overrides
   /// the old one.
   void update({
-    bool? hasPlayed,
-    Duration? position,
-    double? buffered,
     FullScreenOption? fullScreenOption,
     int? volume,
     PlayerState? playerState,
@@ -242,9 +239,6 @@ class YoutubePlayerController implements YoutubePlayerIFrameAPI {
     YoutubeMetaData? metaData,
   }) {
     final updatedValue = YoutubePlayerValue(
-      hasPlayed: hasPlayed ?? value.hasPlayed,
-      position: position ?? value.position,
-      buffered: buffered ?? value.buffered,
       fullScreenOption: fullScreenOption ?? value.fullScreenOption,
       volume: volume ?? value.volume,
       playerState: playerState ?? value.playerState,

diff --git a/packages/youtube_player_iframe/lib/src/player_value.dart b/packages/youtube_player_iframe/lib/src/player_value.dart
@@ -11,9 +11,6 @@ class YoutubePlayerValue {
   /// The duration, current position, buffering state, error state and settings
   /// of a [YoutubePlayerController].
   YoutubePlayerValue({
-    this.hasPlayed = false,
-    this.position = const Duration(),
-    this.buffered = 0.0,
     this.fullScreenOption = const FullScreenOption(enabled: false),
     this.volume = 100,
     this.playerState = PlayerState.unknown,
@@ -23,15 +20,6 @@ class YoutubePlayerValue {
     this.metaData = const YoutubeMetaData(),
   });
 
-  /// Returns true once the video start playing for the first time.
-  final bool hasPlayed;
-
-  /// The current position of the video.
-  final Duration position;
-
-  /// The position up to which the video is buffered.i
-  final double buffered;
-
   /// The initial fullscreen option.
   final FullScreenOption fullScreenOption;
 
@@ -62,12 +50,11 @@ class YoutubePlayerValue {
   String toString() {
     return '$runtimeType('
         'metaData: ${metaData.toString()}, '
-        'position: ${position.inSeconds} sec. , '
-        'buffered: $buffered , '
         'volume: $volume, '
         'playerState: $playerState, '
         'playbackRate: $playbackRate, '
         'playbackQuality: $playbackQuality, '
+        'isFullScreen: ${fullScreenOption.enabled}, '
         'error: $error)';
   }
 }