Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TransferCommitment API #410

Merged
merged 42 commits into from Mar 21, 2024
Merged

Introduce TransferCommitment API #410

merged 42 commits into from Mar 21, 2024

Commits on Mar 15, 2024

  1. Add Skeleton transferCommitment endpoint

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    fe61148 View commit details
    Browse the repository at this point in the history

  2. Add token check

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    fcaab34 View commit details
    Browse the repository at this point in the history

  3. Commitment: Implement commitment GET from DB. Test: Implement DB insert

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    e3c70cf View commit details
    Browse the repository at this point in the history

  4. Test: define working request/response objects

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    98aa497 View commit details
    Browse the repository at this point in the history

  5. Add event logging

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    51c0c8a View commit details
    Browse the repository at this point in the history

  6. Generate transfer token: Implement function to be used in unit test a… 

    …nd production
    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    dcea033 View commit details
    Browse the repository at this point in the history

  7. Add missing changes from last commit

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    6c43ca1 View commit details
    Browse the repository at this point in the history

  8. Finalize: start-transfer API

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    91bb534 View commit details
    Browse the repository at this point in the history

  9. Add transferStatus and token to splitted commitment

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    c8a94a8 View commit details
    Browse the repository at this point in the history

  10. Check: unlisted or public status and amount (greater zero)

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    4cc8f6c View commit details
    Browse the repository at this point in the history

  11. Add sekelton for transfer-commitment API

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    811f866 View commit details
    Browse the repository at this point in the history

  12. Implement Transfer Commitment API logic

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    79a988f View commit details
    Browse the repository at this point in the history

  13. Only allow commitment transfer on confirmed commitments

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    b70b3de View commit details
    Browse the repository at this point in the history

  14. Fix typo in message: project -> commitment

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    30b6ad4 View commit details
    Browse the repository at this point in the history

  15. Update API documentation

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    1278203 View commit details
    Browse the repository at this point in the history

  16. Update docs/users/api-spec-resources.md 

    Co-authored-by: Sandro <sandro.jaeckel@sap.com>
    @VoigtS @SuperSandro2000
    VoigtS and SuperSandro2000 committed Mar 15, 2024
    Copy the full SHA
    94c4816 View commit details
    Browse the repository at this point in the history

  17. Update docs/users/api-spec-resources.md 

    Co-authored-by: Sandro <sandro.jaeckel@sap.com>
    @VoigtS @SuperSandro2000
    VoigtS and SuperSandro2000 committed Mar 15, 2024
    Copy the full SHA
    f4e5423 View commit details
    Browse the repository at this point in the history

  18. Update docs/users/api-spec-resources.md 

    Co-authored-by: Sandro <sandro.jaeckel@sap.com>
    @VoigtS @SuperSandro2000
    VoigtS and SuperSandro2000 committed Mar 15, 2024
    Copy the full SHA
    810c25a View commit details
    Browse the repository at this point in the history

  19. Update docs/users/api-spec-resources.md 

    Co-authored-by: Sandro <sandro.jaeckel@sap.com>
    @VoigtS @SuperSandro2000
    VoigtS and SuperSandro2000 committed Mar 15, 2024
    Copy the full SHA
    fe53bb5 View commit details
    Browse the repository at this point in the history

  20. Update internal/api/utils.go 

    Co-authored-by: Sandro <sandro.jaeckel@sap.com>
    @VoigtS @SuperSandro2000
    VoigtS and SuperSandro2000 committed Mar 15, 2024
    Copy the full SHA
    42b6992 View commit details
    Browse the repository at this point in the history

  21. Return error if project not found

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    94703ba View commit details
    Browse the repository at this point in the history

  22. Tests: Change time usage to clock usage

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    d4c3635 View commit details
    Browse the repository at this point in the history

  23. Add missing error handlings

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    ddc1bca View commit details
    Browse the repository at this point in the history

  24. Update docs/users/api-spec-resources.md 

    Documentation: Fix grammatical indistinctness.

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
    @VoigtS @majewsky
    VoigtS and majewsky committed Mar 15, 2024
    Copy the full SHA
    2f94e47 View commit details
    Browse the repository at this point in the history

  25. Update internal/api/commitment.go 

    Nounify variable names of SQL queries.

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
    @VoigtS @majewsky
    VoigtS and majewsky committed Mar 15, 2024
    Copy the full SHA
    6c3fbe8 View commit details
    Browse the repository at this point in the history

  26. Update internal/api/commitment.go 

    Token check: Remove error return message. Already handled by token.Require function.

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
    @VoigtS @majewsky
    VoigtS and majewsky committed Mar 15, 2024
    Copy the full SHA
    66b7e54 View commit details
    Browse the repository at this point in the history

  27. Update internal/api/commitment.go 

    Rename: splitCommitment function to buildSplitCommitment.

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
    @VoigtS @majewsky
    VoigtS and majewsky committed Mar 15, 2024
    Copy the full SHA
    ccc016d View commit details
    Browse the repository at this point in the history

  28. Update internal/api/commitment_test.go 

    Commitment test: Update parameter from snake case to camel case.

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
    @VoigtS @majewsky
    VoigtS and majewsky committed Mar 15, 2024
    Copy the full SHA
    726f248 View commit details
    Browse the repository at this point in the history

  29. Fix: Remaining Delta from the PR code suggestions

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    00d9ddb View commit details
    Browse the repository at this point in the history

  30. Change naming: GenerateToken to GenerateTransferToken

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    5652337 View commit details
    Browse the repository at this point in the history

  31. Fix: start transfer parseTarget struct now uses explicit fields.

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    c777d8d View commit details
    Browse the repository at this point in the history

  32. Fix: Errors now returned as text. 

    Tests: Negative tests now check the body content
    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    abf3a0f View commit details
    Browse the repository at this point in the history

  33. Request with amount > commitment amount will be treated as an error

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    7a233cc View commit details
    Browse the repository at this point in the history

  34. Update internal/api/commitment.go 

    Simplify commitment transfer. Utilize ORM.

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
    @VoigtS @majewsky
    VoigtS and majewsky committed Mar 15, 2024
    Copy the full SHA
    92de216 View commit details
    Browse the repository at this point in the history

  35. Fix: SQL update now takes both return values into account

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    8af9563 View commit details
    Browse the repository at this point in the history

  36. Fix: remove unused sql update query

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    944f2e6 View commit details
    Browse the repository at this point in the history

  37. Fix: Remove SQL update queries and replace them with proper ORM 

    Update transfer commitment test with split commitment
    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    f49743e View commit details
    Browse the repository at this point in the history

  38. Fix docstring quotes

    @VoigtS
    VoigtS committed Mar 15, 2024
    Copy the full SHA
    0cfc807 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Fix: Transfer Commitment did not use service or resource identifier 

    Caused: on multipyle services or resources the first entry was selected and not the values the source commitments holds
    @VoigtS
    VoigtS committed Mar 19, 2024
    Copy the full SHA
    2553e6c View commit details
    Browse the repository at this point in the history

  2. Transfer commitment: no uses commitment ID and token to get the sourc… 

    …e commitment
    @VoigtS
    VoigtS committed Mar 19, 2024
    Copy the full SHA
    fa512f6 View commit details
    Browse the repository at this point in the history

  3. Transfer commitment: now uses transfer token in header - not as query… 

    …String anymore
    @VoigtS
    VoigtS committed Mar 19, 2024
    Copy the full SHA
    fc307ae View commit details
    Browse the repository at this point in the history

  4. Update transfer commitment documentation 

    Respects the movement of the transfer token as queryString into the header
    @VoigtS
    VoigtS committed Mar 19, 2024
    Copy the full SHA
    7765102 View commit details
    Browse the repository at this point in the history