Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip node replacement if pool is already degraded #644

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Skip node replacement if pool is already degraded #644

wants to merge 3 commits into from

Conversation

jknipper
Copy link
Collaborator

@jknipper jknipper commented Mar 3, 2022

No description provided.

@jknipper jknipper mentioned this pull request Mar 3, 2022
Closed
@databus23
Copy link
Member

Hmm this PR looks like it only modifies the Reboot case not the Replace/Upgrade case

@jknipper
Copy link
Collaborator Author

jknipper commented Mar 4, 2022

Hmm this PR looks like it only modifies the Reboot case not the Replace/Upgrade case

Ah, nice catch. I added it there as well.

@databus23
Copy link
Member

@jknipper Can we merge this?

@jknipper
Copy link
Collaborator Author

jknipper commented May 9, 2022

I need to take a look again if this aged well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@databus23 databus23 databus23 approved these changes

@BugRoger BugRoger Awaiting requested review from BugRoger

@onuryilmaz onuryilmaz Awaiting requested review from onuryilmaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jknipper @databus23