fix(scheduled-publishing): don't include it if it's the only plugin available #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 6, 2024 4:49 PM (UTC)
|
pedrobonamin
changed the title
|
Just a thought on whether there are any tests we can add around this @pedrobonamin ? |
jordanl17
reviewed
May 6, 2024
pedrobonamin
force-pushed
the
fix-scheduled-publishing-tool
branch
from
616c57b
to
e0c3c5e
Compare
Thanks @jordanl17 added some tests for this. |
jordanl17
approved these changes
May 7, 2024
ricokahler
pushed a commit
that referenced
this pull request
May 15, 2024
…vailable (#6530) * fix(scheduled-publishing): don't include the tool if it's the plugin available * chore(core): add tests for resolve default plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the implementation of scheduled publishing as a default feature, when visiting the studio with no plugins added users were seeing the following screen:
Once scheduled publishing was implemented, users no longer see that screen and instead are seeing the schedule publishing tool.
This PR fixes that, and only includes into the plugins array the scheduled publishing tool if other plugins have been added to the source.
Description
What to review
Testing
Notes for release