Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown button is not rendered with selected font. #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

emmanuelgeoffray
Copy link

The issue happens when you call setActiveFont dynamically.

When called dynamically, the dropdown button renders with the previously selected font by mouse click.

@emmanuelgeoffray
Copy link
Author

Hi @samuelmeuli
Did you have a chance to have a look to this ?
Your module is pretty convenient for loading fonts to final user and I hope this fix will help !

@emmanuelgeoffray
Copy link
Author

I've add changes to add a font from url, for fonts outside of Google. As described in #17 .
I've added a sample code in the demo.

To add a font:

fontPicker.addFont('MyFamilyName', 0, 'https://myfonturl')

@ghost
Copy link

ghost commented Mar 7, 2022

@emmanuelgeoffray sad it looks like abandoned.

@samuelmeuli 👉🏻

@emmanuelgeoffray
Copy link
Author

@bacloud22 @samuelmeuli I'm sad too ! Are you already using it or looking for an alternative ?

@ghost
Copy link

ghost commented Mar 7, 2022

@emmanuelgeoffray I am not really using it for anything serious. Using it for a listing web project (classified-ads) but still optional.
I couldn't find any alternative.

Still for its use case, it's beautiful and effective, I'm just afraid of any compatibility questions with Google API/ browsers and modern JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant