Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ACL flag #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support ACL flag #40

wants to merge 4 commits into from

Conversation

odiseo0
Copy link
Contributor

@odiseo0 odiseo0 commented Jan 13, 2023

I also changed the name of BaseConfigProtocol to ConfigProtocol

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what this does, or give a link.

Best if we can keep the default behavior unchanged.

Also good to add some tests.

aioaws/s3.py Outdated
@@ -181,6 +194,7 @@ def signed_upload_url(
size: int,
content_disp: bool = True,
expires: Optional[datetime] = None,
acl: ACLType = "public-read",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best if we can keep the default unchanged.

Copy link
Contributor Author

@odiseo0 odiseo0 Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@odiseo0 odiseo0 Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the ACL Definition

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #40 (89f120c) into main (332855f) will decrease coverage by 0.60%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   96.64%   96.03%   -0.61%     
==========================================
  Files          10       10              
  Lines         626      631       +5     
  Branches      102      103       +1     
==========================================
+ Hits          605      606       +1     
- Misses         15       17       +2     
- Partials        6        8       +2     
Impacted Files Coverage Δ
aioaws/_types.py 100.00% <100.00%> (ø)
aioaws/_utils.py 88.88% <100.00%> (ø)
aioaws/core.py 98.34% <100.00%> (-1.66%) ⬇️
aioaws/s3.py 97.69% <100.00%> (-1.51%) ⬇️
aioaws/ses.py 95.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332855f...89f120c. Read the comment docs.

@odiseo0
Copy link
Contributor Author

odiseo0 commented Jan 13, 2023

Will add some thanks for sure.

Do you mean set the acl to None and only use it in case if set? Okay, no problem

@samuelcolvin
Copy link
Owner

Do you mean set the acl to None and only use it in case if set? Okay, no problem

Exactly

@odiseo0
Copy link
Contributor Author

odiseo0 commented Jan 13, 2023

Will do, thanks so much for the feedback

@odiseo0
Copy link
Contributor Author

odiseo0 commented Jan 31, 2023

This PR it's ready for review, I've been using my fork and the ACL flag it's working correctly. Thanks for this small library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants