Make dist and distcheck targets #682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-generated files have no place in git and cause erroneous conflicts.
mcshane
reviewed
May 15, 2017
configure.ac
Outdated
| @@ -23,7 +23,7 @@ | |||
| # DEALINGS IN THE SOFTWARE. | |||
|
|
|||
| dnl Process this file with autoconf to produce a configure script | |||
| AC_INIT([Samtools], m4_esyscmd_s([make print-version]), | |||
| AC_INIT([Samtools], m4_esyscmd_s([./version 2>/dev/null]), | |||
There was a problem hiding this comment.
Ah yes. Curious it works though! Thanks for the spot.
Also removed PACKAGE_VERSION hard coded values from misc/maq2sam and misc/wgsim. This also needed code to explicitly duplicate what autoconf does - ugh why do we insist on maintaining this schitsophrenic build system?
|
I haven't done bcftools yet but was waiting on feedback for the samtools equivalent first, and for the bcftools autoconf branch to be merged. Any feedback on this so far? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partly to replace the c-maint repository and additionally to add the ability to validate the tar balls is constructed correctly by unpacking, building and testing.
It is excessively messy getting this to work with the joint samtools/htslib tarball due to the catch-22 nature of having config.mk specify the HTSDIR and being included and used within Makefile targets in a circular fashion. However it does at least appear to work!
Differences to the c-maint one are the addiction of the acinclude.m4 (I am unsure if this is correct or not, but it's here while I mull it over) and the lack of changing time stamps within the tar. It does guarantee that configure post-dates the rest of the tar ball however.