Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the CRAM Base Substitution (BS) code explanation #703

Merged
merged 1 commit into from
May 22, 2023

Conversation

jkbonfield
Copy link
Contributor

Fixes #408

@jkbonfield jkbonfield added the cram label Feb 9, 2023
@jkbonfield
Copy link
Contributor Author

@jmarshall This fails checks because latexdiff fails, and not because building the PDF from the main TeX fails.

The error details above show the command as:

make new/CRAMv3.pdf  && make -k OLD=$mergebase_sha NEW=HEAD diff/CRAMv3.pdf 

I'm wondering if we should replace it in pr-pds.yaml with

run: make ${{ env.pdfs }} && (make -k OLD=$mergebase_sha NEW=HEAD ${{ env.diffs }} || true)

so even when the diff fails, provided the primary document builds correctly then we're still OK.

What do you think? I wouldn't mind if it weren't for latexdiff being such a buggy mess. I've had numerous tables break with it sadly. Sometimes I've rewritten them until it works, but it feels a bit like tail wagging the dog. The preview is nice to have, but should never cause a CI failure IMO.

@jmarshall
Copy link
Member

jmarshall commented Feb 10, 2023

That's what make -k was supposed to be there for (to ignore the error if one of several diff PDFs spuriously fails), but of course it doesn't actually stop the exit status from being non-zero — d'oh. We could use what you've suggested or about equivalently make -i to really ignore errors, but I've long been vaguely dissatisfied by the && joining what are really separate commands, so I've made run.sh more fancy instead.

Rebase onto master again to get c044c04 and this should finally go away.

@github-actions
Copy link

Changed PDFs as of 4c631b4: CRAMv3.

@jkbonfield
Copy link
Contributor Author

Thanks @jmarshall

@github-actions
Copy link

Changed PDFs as of 9eb4b32: CRAMv3.

@github-actions
Copy link

Changed PDFs as of 40beee1: CRAMv3.

@jkbonfield jkbonfield merged commit 40beee1 into samtools:master May 22, 2023
1 check passed
@jkbonfield jkbonfield temporarily deployed to github-pages May 22, 2023 13:28 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAM spec read feature clarifications
2 participants