Spell out slice md5sums interaction with embedded references #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also clarifies that an embedded reference is not required to exactly match any known external references nor the one used to originally align against. Fixes samtools#357. Also fixes samtools#453 as the one remaining part left was the interaction of MD/NM and embedded references.
jkbonfield
force-pushed
the
embedded_ref_md5
branch
from
41b0e76
to
34b37e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also clarifies that an embedded reference is not required to exactly match any known external references nor the one used to originally align against.
Fixes #357.
Also fixes #453 as the one remaining part left was the interaction of MD/NM and embedded references.