Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ##PEDIGREE example typographical errors #583

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

jmarshall
Copy link
Member

PR #413 both fixed some typographical errors in ##PEDIGREE examples and added a new section describing previously undescribed ##PEDIGREE usage. It has been bogged down for two years as the details of the latter were debated for a while and then ignored.

This PR pulls out the first commit of that, which fixes obvious typographical errors (or possibly transcription errors from when the original g1k wiki VCF text was converted to LaTeX) in the ##PEDIGREE examples in one section of each spec, and updates it to also fix the errors duplicated into VCFv4.4.draft.tex.

This PR simply fixes existing typographical errors in the VCF specs and should be able to be merged without undue delay.

Add ## to the ##PEDIGREE line examples. Add the missing words
to the description of the ID2/ID1 / DerivedID/OriginalID clonal
pedigree (for VCFv4.2.tex, this was already done in PR samtools#176).
Add missing word "trio" to "one entry per [] of the form".
@hts-specs-bot
Copy link

Changed PDFs as of dcbe7b6: VCFv4.1 (diff), VCFv4.2 (diff), VCFv4.3 (diff), VCFv4.4.draft (diff).

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarshall Looks good, thanks for cleaning this up.

@lbergelson lbergelson merged commit 1715701 into samtools:master Jul 27, 2021
@jmarshall jmarshall deleted the pedigree-typos branch July 27, 2021 19:50
tcezard pushed a commit to tcezard/hts-specs that referenced this pull request Aug 19, 2021
Add ## to the ##PEDIGREE line examples. Add the missing words
to the description of the ID2/ID1 / DerivedID/OriginalID clonal
pedigree (for VCFv4.2.tex, this was already done in PR samtools#176).
Add missing word "trio" to "one entry per [] of the form".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants