Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

Albert/support obj 2 #537

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Albert/support obj 2 #537

wants to merge 3 commits into from

Conversation

alberttjin
Copy link
Contributor

No description provided.

alberttjin added 3 commits January 12, 2023 15:40
Sometimes its easier to define an object as a federation key rather than
re-fetching the object from the db. It can also be more cost efficient
if its difficult to fetch it from the database.

However, to support this, the selection set needs to recursively list
all fields under all objects that are selected as keys. This commit adds
that support and also a comment explanation
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3623

  • 32 of 101 (31.68%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 65.887%

Changes Missing Coverage Covered Lines Changed/Added Lines %
federation/planner_helpers.go 30 99 30.3%
Files with Coverage Reduction New Missed Lines %
graphql/schemabuilder/input.go 6 60.4%
Totals Coverage Status
Change from base Build 3608: -0.4%
Covered Lines: 6250
Relevant Lines: 9486

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants