Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass closure as logger configuration option #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow to pass closure as logger configuration option #36

wants to merge 1 commit into from

Conversation

kminek
Copy link
Contributor

@kminek kminek commented Apr 16, 2023

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@kminek kminek mentioned this pull request Apr 16, 2023
Open
@samdark
Copy link
Owner

samdark commented Apr 16, 2023

That should work. @brandonkelly, would you please confirm?

@brandonkelly
Copy link

brandonkelly commented Apr 16, 2023 •
edited

Similar problem with that – we’re overriding $target as a protected property (because that’s what it currently is in LoggerAwareTrait).

So now PHPStan is reporting:

Protected property craft\log\MonologTarget::$logger overriding public property samdark\log\PsrTarget::$logger should also be public.

Either one of these changes are fine if you just release it with a major version bump, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kminek @samdark @brandonkelly