Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suse): update pygit2 package name #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tacerus
Copy link

@tacerus tacerus commented Sep 26, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Update package name to resolve Package 'python-pygit2' not found..

Pillar / config required to test the proposed changes

n/a

Debug log showing how the proposed changes work

n/a

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

On modern SUSE distributions, Python module package names
will only resolve with the python3- prefix.

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
@tacerus tacerus requested review from myii and a team as code owners September 26, 2023 08:23
@tacerus
Copy link
Author

tacerus commented Sep 26, 2023

The pre-commit error does not sound like related to my changes?

@jeff350 jeff350 mentioned this pull request Oct 3, 2023
19 tasks
@denyka
Copy link

denyka commented Jan 3, 2024

You can use a construction in your pillar like

salt:
    lookup:
      pygit2: python3-pygit2
      python_git: python3-gitpython

to solve the problem like with the missing package

@tacerus
Copy link
Author

tacerus commented Jan 3, 2024

Thank you, @denyka. That's useful.
It would however still be great to have it repaired in the formula code, as the old packages (Python 2) no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants