Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Option to not include profile picture #391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Feature] Option to not include profile picture #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a50677
added new key for photo
prashantswami May 30, 2021
b17e2e2
created computed property
prashantswami May 30, 2021
fa8cbe8
changes to templates
prashantswami May 30, 2021
7ed5d6c
by default photo should be visible
prashantswami May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions resume/data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ name:
about: Hi, my name is John Doe. I"m just about the most boring type of person you could
possibly imagine. I like collecting leaves from the tree in my back yard and documenting
each time I eat a peanut that is non-uniform. I am not a robot. Please hire me.
photo: true
position: Software Developer

birth:
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/cool-rtl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
</div>
</div>

<img class="picture"/>
<img class="picture" v-if="isPhotoAvailable"/>
</div>
</template>

Expand Down
2 changes: 1 addition & 1 deletion src/resumes/cool-rtl2.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
</div>
</div>

<img class="picture"/>
<img class="picture" v-if="isPhotoAvailable" />

</div>
</template>
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/cool.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
</div>
</div>

<img class="picture"/>
<img class="picture" v-if="isPhotoAvailable" />
</div>
</template>

Expand Down
2 changes: 1 addition & 1 deletion src/resumes/left-right-projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="row text-center">
<p class="position center">{{person.position}}</p>
</div>
<div class="row">
<div class="row" v-if="isPhotoAvailable">
<div class="image center">
<div class="img"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/left-right-rtl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="row text-center">
<p class="position center">{{person.position}}</p>
</div>
<div class="row">
<div class="row" v-if="isPhotoAvailable">
<div class="image center">
<div class="img"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/left-right.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="row text-center">
<p class="position center">{{person.position}}</p>
</div>
<div class="row">
<div class="row" v-if="isPhotoAvailable">
<div class="image center">
<div class="img"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/material-dark-projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="resume">
<div class="leftCol m_box">
<div class="shadow"></div>
<div class="heading" id="myselfpic">
<div class="heading" id="myselfpic" v-if="isPhotoAvailable">
</div>
<div class="section-headline">
Contact
Expand Down
6 changes: 3 additions & 3 deletions src/resumes/material-dark.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="resume">
<div class="leftCol m_box">
<div class="shadow"></div>
<div class="heading" id="myselfpic">
<div class="heading" id="myselfpic" v-if="isPhotoAvailable">
</div>
<div class="section-headline">
{{ lang.contact }}
Expand Down Expand Up @@ -119,7 +119,7 @@
<div class="subheadline">{{experience.timeperiod}}</div>
<p class="info">
{{experience.description}}
</p>
</p>
</a>
</div>
<div class="section-headline">{{ lang.education }}</div>
Expand Down Expand Up @@ -474,7 +474,7 @@ h4 {
}
}
}
.item.last{
.item.last{
.text {
border-bottom-style:none;
padding-bottom:0;
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/oblique-projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="name">{{person.name.first}} {{person.name.last}}</div>
<div class="position">{{person.position}}</div>
</div>
<div class="img">
<div class="img" v-if="isPhotoAvailable">
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/resumes/oblique-rtl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="name">{{person.name.first}} {{person.name.middle}} {{person.name.last}}</div>
<div class="position">{{person.position}}</div>
</div>
<div class="img">
<div class="img" v-if="isPhotoAvailable">
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/resumes/oblique.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="name">{{person.name.first}} {{person.name.middle}} {{person.name.last}}</div>
<div class="position">{{person.position}}</div>
</div>
<div class="img">
<div class="img" v-if="isPhotoAvailable">
</div>
</div>

Expand Down
4 changes: 4 additions & 0 deletions src/resumes/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ function getVueOptions (name) {

return links;
},

isPhotoAvailable() {
return Boolean(this.person.photo);
}
}
};
return opt;
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/side-bar-projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<span class="person-position"> {{person.position}} </span>
</div>
<div class="left-col">
<div class="person-image">
<div class="person-image" v-if="isPhotoAvailable">
<div class="image-centerer">
<div class="img"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/side-bar-rtl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</span>
</div>
<div class="right-col">
<div class="person-image">
<div class="person-image" v-if="isPhotoAvailable">
<div class="image-centerer">
<div class="img"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/resumes/side-bar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</span>
</div>
<div class="left-col">
<div class="person-image">
<div class="person-image" v-if="isPhotoAvailable">
<div class="image-centerer">
<div class="img"></div>
</div>
Expand Down