Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pycuda unit tests after example script migration #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UsaidPro
Copy link

Hello! I had a test failure running the python warp_drive/utils/unittests/run_trainer_tests.py unit test in the README from the below error:

ImportError while importing test module '/home/usaidm/Documents/ExternalLibs/warp-drive/tests/wd_training/pycuda_tests/test_env_training.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../.pyenv/versions/3.8.10/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/wd_training/pycuda_tests/test_env_training.py:14: in <module>
    from warp_drive.training.example_training_script_pycuda import setup_trainer_and_train
E   ModuleNotFoundError: No module named 'warp_drive.training.example_training_script_pycuda'

Decided to fix and submit a pull request since it is a small fix. Hope it helps!

After making this change, the unit test succeeds.

Copy link

Thanks for the contribution! Before we can merge this, we need @UsaidPro to sign the Salesforce Inc. Contributor License Agreement.

@UsaidPro
Copy link
Author

UsaidPro commented Mar 26, 2024

Tried signing the CLA but got this failure: Could not sign the CLA, please contact: oss-bots@salesforce.com. :(

EDIT: Clicking on the CLA link again results in a page stating "You have already signed the CLA Agreement". Is it possible to rerun the check?

@Emerald01
Copy link
Collaborator

Emerald01 commented Mar 26, 2024

@UsaidPro
Thank you for fixing this. I have approved your PR.
Regarding this CLA, could you please refresh and check if it works? I am not sure why it is not working on your side, if it is still not working, please let me know, I can ask our open source team to find the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants