Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10404 - Compare parentenum_value more precisely #10406

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

ojs87
Copy link
Contributor

@ojs87 ojs87 commented Apr 16, 2024

Description

If a Mass Update is performed on a module containing dynamic fields with underscores in parent field keys, the child field's default value is always set, regardless if a change has been made to the dynamic parent field. This issue is closely related to #8209 however the proposed fix in #10340 does not fix this issue if a custom dynamic dropdown is still in the Cases module and this can happen with no change to the dynamic dropdowns.

examples of dynamic dropdown options that would be affected:

parent dropdown keys: 
health_and_safety

child option keys:
health_and_safety_fire
health_and_safety_power_cut
health_and_safety_volcano

Motivation and Context

Mass Update on many records can cause many unwanted changes to dynamic dropdowns

How To Test This

  1. Add a dynamic dropdown with keys containing underscores to a module
  2. Create a record and set the child value to non-default(not the first value)
  3. Perform a mass update on the record, with no changes to the dynamic dropdowns
  4. The dynamic dropdown child field will be set to the default value.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Apr 23, 2024
@serhiisamko091184
Copy link
Contributor

Hi @ojs87,

thanks for your contribution!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants