Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDF rendering issues #10402

Merged
merged 2 commits into from May 14, 2024
Merged

Fix PDF rendering issues #10402

merged 2 commits into from May 14, 2024

Conversation

mattlorimer
Copy link
Member

@mattlorimer mattlorimer commented Apr 15, 2024 •
edited

Description

Addresses PDF related issues #10401 and #10376

Motivation and Context

See #10401 & #10376

How To Test This

See #10401 & #10376

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@mattlorimer mattlorimer changed the title Fix/pdf issues Fix PDF rendering issues Apr 15, 2024
@serhiisamko091184 serhiisamko091184 added Area: PDFs Issues & PRs related to all things regarding PDFs Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review labels Apr 16, 2024
@serhiisamko091184
Copy link
Contributor

Hi @mattlorimer,

thanks for your PR!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels May 1, 2024
@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels May 2, 2024
@jack7anderson7 jack7anderson7 merged commit d313e81 into salesagility:hotfix May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnM2401 johnM2401 johnM2401 approved these changes

@jack7anderson7 jack7anderson7 jack7anderson7 approved these changes

Assignees
No one assigned
Labels
Area: PDFs Issues & PRs related to all things regarding PDFs Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattlorimer @serhiisamko091184 @johnM2401 @jack7anderson7