Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1502003 Fix Bug Undefined index when create dropdown fields from mod… #10391

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from

Conversation

HENILCODES
Copy link

@HENILCODES HENILCODES commented Apr 5, 2024

…ule builder. Update enum2.php

When Create Dropdown Field from module builder then show error like this:

Notice: Undefined index: in D:\xampp\htdocs\projects\dev\tps\modules\DynamicFields\templates\Fields\Forms\dynamicenum.php on line 100 {"east":{"title":"Edit Field","crumb":"","content":" </div>\n\n

Description

When Create drop down field in Module builder it display some undefine error.

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…ule builder. Update enum2.php

When Create Dropdown Field from module builder then show error like this:

Notice: Undefined index: in D:\xampp\htdocs\projects\dev\tps\modules\DynamicFields\templates\Fields\Forms\dynamicenum.php on line 100
{"east":{"title":"Edit Field","crumb":"","content":"
<\/div>\n\n
@SuiteBot
Copy link

SuiteBot commented Apr 5, 2024

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184
Copy link
Contributor

Hello @HENILCODES,

thanks for your contribution, could you, please:

  1. sign the Contributor License Agreement. We can accept your contribution only after signing CLA.
    image

  2. update your commit message to format (in this case the number in commit message is the number of your PR, 10391):
    Fix #1502003 Fix Bug Undefined index when create dropdown fields from mod… #10391 - your commit message
    As example:
    image
    For more information, please, visit: https://docs.suitecrm.com/community/contributing-code/bugs/

  3. provide more information on the issue within the PR template - add detailed replication steps and check the checkboxes where appropriate.

Thanks in advance!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Apr 5, 2024
@HENILCODES
Copy link
Author

Complete

@HENILCODES HENILCODES closed this Apr 5, 2024
@HENILCODES HENILCODES reopened this Apr 5, 2024
@serhiisamko091184
Copy link
Contributor

Hello @HENILCODES,

thanks a lot for your reply and the changes made.

Could you please combine 2 commits into one and update it as suggested in item 2 of my previous commit?

at the moment:

image

we'd like you to have:

image

Could you also be more specific on this particular issue?
image

Thank you so much!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants