Fix #10375 - Upgradewizard double commit #10375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that "commit" is called twice when runing the upgradewizard caused by changes in:
890e599#diff-7c5c0ada659df5cc72d508d4b597f1882ede2ee19a4a243010a84b9a3a8b4213
Description
The changes in the said commit introduce the variable $additionalStep in modules/Upgradewizard/index.php
This variable is initalized in line 509, but already used before in line 297 without initialization. This causes the commit.php to be executed twice.
Motivation and Context
As commit.php is secured to not run its logic twice, this bug does not have any implications for now, however future changes might cause an issue here.
How To Test This
Expected result
commit.php is only called once
Observed behaviour
the file
upgradewizard.log
shows two entries of the line "[At commit.php]"This can also be verified by debugger.
Types of changes
Final checklist