Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10364 - Adding now option and minute sensibility in Datetime fields #10368

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

@SinergiaCRM SinergiaCRM commented Feb 26, 2024

Description

In this PR, the option "now" is added to the default value list in the datetime field editing in the Studio module. Additionally, the internal value of the "today" item has been modified, as it was already using the value "now".

Furthermore, the variable datetime_combo_minute_interval is created to indicate the interval of minutes that will be displayed in datetime fields, in case the default value of every 15 minutes is not desired.

Additionally, the sensitivity of the minute hand of datetime fields whose default value is "now" is modified. The sensitivity is set to 1 so that the minutes are always displayed correctly.

Motivation and Context

This change is required to enhance the functionality of the datetime fields in the Studio module. It adds flexibility by allowing the option "now" and enables customization of the minute interval displayed in datetime fields.

How To Test This

  1. Open the Studio module.
  2. Navigate to the editing section of a datetime field.
  3. Verify that "now" is included in the default value list.
  4. Select "now" option and allow MassUpdate.
  5. Go to the edit view and make sure that the minute field is now set to 1 by 1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SinergiaCRM SinergiaCRM reopened this Feb 26, 2024
@SinergiaCRM SinergiaCRM changed the title Fix #10364 - Adding now option in Datetime fields (Work in Progress)Fix #10364 - Adding now option in Datetime fields Feb 26, 2024
@PaulaaSTIC PaulaaSTIC force-pushed the fix_10364 branch 3 times, most recently from aa412c8 to e869aa4 Compare February 27, 2024 09:08
@SinergiaCRM SinergiaCRM changed the title (Work in Progress)Fix #10364 - Adding now option in Datetime fields Fix #10364 - Adding now option in Datetime fields Feb 27, 2024
@serhiisamko091184
Copy link
Contributor

Hi @SinergiaCRM,

Thanks for your PR!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added PR:Type:Enhancement Pull requests that provide more functionality. Associated Issues are called suggestions Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 9-14 Score given to PRs once assessed labels Feb 27, 2024
@SinergiaCRM SinergiaCRM changed the title Fix #10364 - Adding now option in Datetime fields Fix #10364 - Adding now option and minute sensibility in Datetime fields Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR:Type:Enhancement Pull requests that provide more functionality. Associated Issues are called suggestions PR 9-14 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding now option and minute sensibility in Datetime fields.
2 participants