Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transactionUpdate/transactionCreate with empty metadata #15888

Merged
merged 2 commits into from May 8, 2024

Conversation

tomaszszymanski129
Copy link
Member

I want to merge this change because it fixes fields metadata and private_metadata breaking when null (allowed by schema) is provided in the mutation (500).

Context: https://linear.app/saleor/issue/SHOPX-550/null-in-metadata-returns-a-internal-server-error-mutation

⚠️ This is a port of #15875

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@tomaszszymanski129 tomaszszymanski129 marked this pull request as ready for review April 26, 2024 11:49
@tomaszszymanski129 tomaszszymanski129 requested a review from a team April 26, 2024 11:49
@db-queries
Copy link

db-queries bot commented Apr 26, 2024

Here is the report for 6368334 (saleor:fix-transaction-update-metadata-316)
Missing base report (12c1ef0). The results couldn't be compared.

No differences were found.

@IKarbowiak IKarbowiak requested a review from a team April 29, 2024 07:07
@tomaszszymanski129 tomaszszymanski129 merged commit a429349 into 3.16 May 8, 2024
3 checks passed
@tomaszszymanski129 tomaszszymanski129 deleted the fix-transaction-update-metadata-316 branch May 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants