Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discounts resolver to work like in docs #15883

Merged
merged 4 commits into from May 10, 2024

Conversation

tomaszszymanski129
Copy link
Member

I want to merge this change because it fixes discounts resolver to work like in docs
more context: https://linear.app/saleor/issue/SHOPX-325/bug-discounts-field-behaviour-on-calculatetaxes-event-is-inconsistent

⚠️ This is a port of #15863

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@tomaszszymanski129 tomaszszymanski129 marked this pull request as ready for review April 26, 2024 11:47
@tomaszszymanski129 tomaszszymanski129 requested a review from a team April 26, 2024 11:48
@db-queries
Copy link

db-queries bot commented Apr 26, 2024

Here is the report for 3bb5600 (saleor:fix-discounts-resolver-317)
Missing base report (ec3e070). The results couldn't be compared.

No differences were found.

@tomaszszymanski129 tomaszszymanski129 merged commit cccc990 into 3.17 May 10, 2024
5 checks passed
@tomaszszymanski129 tomaszszymanski129 deleted the fix-discounts-resolver-317 branch May 10, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants