Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Ruby 3.1 and 3.2 #72

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Test for Ruby 3.1 and 3.2 #72

merged 3 commits into from
Dec 27, 2023

Conversation

bautrey37
Copy link
Contributor

@bautrey37 bautrey37 commented Oct 12, 2023

Adding Ruby 3.1 and 3.2 to the testing CI to make sure that these versions don't have any hidden bugs in them.

Also, found some old code that can be reverted, because all services are on dry-* v1+.

The `ruby/setup-ruby` Github Action had to be updated in order to
retrieve Ruby 3.1 nad 3.2.
@bautrey37 bautrey37 force-pushed the expand-ruby-testing branch 2 times, most recently from 69cb41b to 7e811b1 Compare October 12, 2023 08:58
This reverts commit 7b835c6.

All our services are running on dry-* gems v1+.
@bautrey37 bautrey37 requested a review from sviik October 12, 2023 09:07
@bautrey37 bautrey37 marked this pull request as ready for review October 12, 2023 09:07
@sviik sviik removed their request for review October 17, 2023 07:20
@bautrey37 bautrey37 requested a review from tluik December 27, 2023 15:43
@bautrey37
Copy link
Contributor Author

I forgot about this PR. It seems ready to be merged as CI shows it is passing.

Copy link

@tluik tluik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bautrey37
Copy link
Contributor Author

!merge

@sm-deployer sm-deployer merged commit 623be41 into master Dec 27, 2023
8 checks passed
@sm-deployer sm-deployer deleted the expand-ruby-testing branch December 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants