Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test fix #221

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

npm test fix #221

wants to merge 6 commits into from

Conversation

yfdyh000
Copy link
Contributor

@yfdyh000 yfdyh000 commented Jul 1, 2022

This fixes the default build not working, eslint issues and the .travis.yml fail.

I also recommend you provide the travis-ci URL in README file.

@salarcode
Copy link
Owner

Good cleanup, thanks.
But I don't want to include files in libs-unzip-before-build.zip in source.
Would be nice to unzip with build but I couldn't find a decent webpack-plugin to unzip them during build either...

@yfdyh000
Copy link
Contributor Author

yfdyh000 commented Jul 4, 2022

But I don't want to include files in libs-unzip-before-build.zip in source.

I don't understand, this is bad for auditing and git compression.

@salarcode
Copy link
Owner

Can you revert the changes to src/ui/js/ please? the unzip is part of build now.
So we can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants